Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flutter engine license location #11594

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Update Flutter engine license location #11594

merged 2 commits into from
Jan 21, 2025

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jan 15, 2025 •
edited
Loading

Flutter engine license location changed after the monorepo merge.

Part of #11595

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@loic-sharma loic-sharma requested a review from jtmcdole January 15, 2025 23:14
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jan 15, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6a90748):

https://flutter-docs-prod--pr11594-loic-sharma-patch-1-t7w5lerk.web.app

sfshaza2
sfshaza2 requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@loic-sharma loic-sharma requested a review from sfshaza2 January 17, 2025 18:04
sfshaza2
sfshaza2 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 5ec6ab1 into main Jan 21, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the loic-sharma-patch-1 branch January 21, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough parlough approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

@antfitch antfitch Awaiting requested review from antfitch antfitch is a code owner

Assignees

@sfshaza2 sfshaza2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loic-sharma @flutter-website-bot @jtmcdole @parlough @sfshaza2